Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: resolve TODO related to inspector CVEs #45341

Merged
merged 1 commit into from Nov 6, 2022
Merged

src: resolve TODO related to inspector CVEs #45341

merged 1 commit into from Nov 6, 2022

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Nov 6, 2022

This was not done before the security release because the latest CVE was not known at the time.

@tniessen
src: resolve TODO related to inspector CVEs
b291118 
This was not done before the security release because the latest CVE was
not known at the time.
@tniessen tniessen added security Issues and PRs related to security. inspector Issues and PRs related to the V8 inspector protocol labels Nov 6, 2022
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 6, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47740/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47745/

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7903f94 into nodejs:main Nov 6, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7903f94

This was referenced Nov 7, 2022
Open
Open
Open
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
@tniessen @lucshi
src: resolve TODO related to inspector CVEs
5e90a13 
This was not done before the security release because the latest CVE was
not known at the time.

PR-URL: nodejs#45341
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Open
20 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@tniessen @RafaelGSS
src: resolve TODO related to inspector CVEs
326d19a 
This was not done before the security release because the latest CVE was
not known at the time.

PR-URL: #45341
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@tniessen @danielleadams
src: resolve TODO related to inspector CVEs
9314d09 
This was not done before the security release because the latest CVE was
not known at the time.

PR-URL: #45341
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@tniessen @danielleadams
src: resolve TODO related to inspector CVEs
9c23dab 
This was not done before the security release because the latest CVE was
not known at the time.

PR-URL: #45341
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@tniessen @danielleadams
src: resolve TODO related to inspector CVEs
89b3336 
This was not done before the security release because the latest CVE was
not known at the time.

PR-URL: #45341
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@tniessen @danielleadams
src: resolve TODO related to inspector CVEs
c66ae82 
This was not done before the security release because the latest CVE was
not known at the time.

PR-URL: #45341
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@anonrig anonrig anonrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. security Issues and PRs related to security.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tniessen @nodejs-github-bot @Trott @anonrig @BridgeAR